Alon Bar-Lev has posted comments on this change. Change subject: core: enable ConfigValues injection ......................................................................
Patch Set 2: ok... I as primitive representation... do not understand the difference between injection and ConfigValues.get(<>)... I think the later is simpler and easier to manage. but of course it is only me... had we had global engine context, in which we store all current singletones, and offer the ability to inject that context, while ConfigValues is part of that, I would have seen the benefit. in theory (and in practice) it would have allowed two engine instances running at same jvm, this is something I like to see. -- To view, visit http://gerrit.ovirt.org/29539 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I63c4d5f6239d5f4fd7737f9637d1a6e999020b1b Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Arik Hadas <[email protected]> Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: Liran Zelkha <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: Vojtech Szocs <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
