Gilad Chaplik has posted comments on this change. Change subject: core: disk profile commands and queries ......................................................................
Patch Set 11: (3 comments) new patch to follow. http://gerrit.ovirt.org/#/c/28732/11/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/profiles/DiskProfileValidator.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/profiles/DiskProfileValidator.java: Line 15: Line 16: public class DiskProfileValidator { Line 17: Line 18: private final DiskProfile diskProfile; Line 19: private DiskProfile diskProfileFronDb; > s/diskProfileFronDb/diskProfileFromDb Done Line 20: private StorageDomain storageDomain; Line 21: private List<DiskProfile> diskProfiles; Line 22: Line 23: public DiskProfileValidator(DiskProfile diskProfile) { Line 94: Line 95: return diskProfiles; Line 96: } Line 97: Line 98: protected DiskProfile getOldDiskProfile() { > s/getOldDiskProfile/getDiskProfileFromDb Done Line 99: if (diskProfileFronDb == null) { Line 100: diskProfileFronDb = getDbFacade().getDiskProfileDao().get(diskProfile.getId()); Line 101: } Line 102: http://gerrit.ovirt.org/#/c/28732/11/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/DiskProfileParameters.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/DiskProfileParameters.java: Line 11: } Line 12: Line 13: public DiskProfileParameters(DiskProfile diskProfile, Guid diskProfileId) { Line 14: super(diskProfile, diskProfileId); Line 15: } > setters/getters? soon, all the parameter classes will be persisted.. look at parent :-) -- To view, visit http://gerrit.ovirt.org/28732 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0d871f1603671bc14ce88c68f85638b1af67f5e1 Gerrit-PatchSet: 11 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Arik Hadas <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Doron Fediuck <[email protected]> Gerrit-Reviewer: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Kobi Ianko <[email protected]> Gerrit-Reviewer: Liron Aravot <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
