Gilad Chaplik has posted comments on this change. Change subject: core: disk profile commands and queries ......................................................................
Patch Set 11: (1 comment) http://gerrit.ovirt.org/#/c/28732/11/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/profiles/RemoveDiskProfileCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/profiles/RemoveDiskProfileCommand.java: Line 33: public List<PermissionSubject> getPermissionCheckSubjects() { Line 34: return Collections.singletonList(new PermissionSubject(getParameters().getProfile() != null ? getParameters().getProfile() Line 35: .getStorageDomainId() Line 36: : null, Line 37: VdcObjectType.Storage, getActionType().getActionGroup())); should be diskProfileId on DiskProfile Line 38: } Line 39: Line 40: @Override Line 41: protected void setActionMessageParameters() { -- To view, visit http://gerrit.ovirt.org/28732 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0d871f1603671bc14ce88c68f85638b1af67f5e1 Gerrit-PatchSet: 11 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Arik Hadas <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Doron Fediuck <[email protected]> Gerrit-Reviewer: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Kobi Ianko <[email protected]> Gerrit-Reviewer: Liron Aravot <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
