Piotr Kliczewski has posted comments on this change. Change subject: jsonrpc: client side heartbeat implementation ......................................................................
Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/30165/2/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java: Line 52: * Timeout in seconds how often we should receive heart-beat. Line 53: */ Line 54: @TypeConverterAttribute(Integer.class) Line 55: @DefaultValueAttribute("10") Line 56: vdsHeartBeat, > s/vdsHeartBeat/vdsHeartbeat Done Line 57: Line 58: /** Line 59: * Timeout for establishment of connections with hosts. This should be quite Line 60: * small, a few seconds at most, as it the TCP handshake with hosts should -- To view, visit http://gerrit.ovirt.org/30165 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9e8a20592542ce1a754dee1917ff9ebba6b8daf9 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Barak Azulay <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
