Yair Zaslavsky has posted comments on this change. Change subject: jsonrpc: client side heartbeat implementation ......................................................................
Patch Set 3: (3 comments) http://gerrit.ovirt.org/#/c/30165/3/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java: Line 195: Line 196: // Get the values of the timeouts: Line 197: int clientTimeOut = Config.<Integer> getValue(ConfigValues.vdsTimeout) * 1000; Line 198: int connectionTimeOut = Config.<Integer> getValue(ConfigValues.vdsConnectionTimeout) * 1000; Line 199: int heartBeat = Config.<Integer> getValue(ConfigValues.vdsHeartbeat) * 1000; same question as before, about the value of heart beat.. Line 200: int clientRetries = Config.<Integer> getValue(ConfigValues.vdsRetries); Line 201: _vdsProxy = TransportFactory.createVdsServer(_vds.getProtocol(), _vds.getHostName(), _vds.getPort(), clientTimeOut, connectionTimeOut, clientRetries, heartBeat); Line 202: } Line 203: http://gerrit.ovirt.org/#/c/30165/3/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsProxyData.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsProxyData.java: Line 564: if (host != null) { Line 565: // Get the values of the timeouts: Line 566: int clientTimeOut = Config.<Integer> getValue(ConfigValues.vdsTimeout) * 1000; Line 567: int connectionTimeOut = Config.<Integer> getValue(ConfigValues.vdsConnectionTimeout) * 1000; Line 568: int heartBeat = Config.<Integer> getValue(ConfigValues.vdsHeartbeat) * 1000; i got confused. you're getting here a value of 10,000 seconds, is this intentional? Maybe this proves my point in the previous comment, or maybe I don't understand how often heart beat should be carried? :) Line 569: int clientRetries = Config.<Integer> getValue(ConfigValues.vdsRetries); Line 570: irsProxy = TransportFactory.createIrsServer(getProtocol(), host, getmIrsPort(), clientTimeOut, connectionTimeOut, clientRetries, heartBeat); Line 571: runStoragePoolUpEvent(storagePool); Line 572: } http://gerrit.ovirt.org/#/c/30165/3/packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql File packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql: Line 645: select fn_db_add_config_value('VdsLocalDisksLowFreeSpace','500','general'); Line 646: select fn_db_add_config_value('VdsRecoveryTimeoutInMinutes','3','general'); Line 647: select fn_db_add_config_value('VdsRefreshRate','2','general'); Line 648: select fn_db_add_config_value('vdsRetries','0','general'); Line 649: select fn_db_add_config_value('vdsHeartbeat','10','general'); Please sort alphabeitallcay, well, at least in the group of vds keys :) Also, I know there is inconsistency in the keys names, but mybe worth mentioning that this is "inSeconds" in the key name? Line 650: --Handling Host Selection Algorithm default for cluster Line 651: select fn_db_add_config_value('VdsSelectionAlgorithm','None','general'); Line 652: select fn_db_add_config_value('vdsTimeout','180','general'); Line 653: --Handling Virtual Machine Domain Name -- To view, visit http://gerrit.ovirt.org/30165 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9e8a20592542ce1a754dee1917ff9ebba6b8daf9 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Barak Azulay <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
