Yair Zaslavsky has posted comments on this change. Change subject: jsonrpc: client side heartbeat implementation ......................................................................
Patch Set 3: (1 comment) http://gerrit.ovirt.org/#/c/30165/3/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsProxyData.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsProxyData.java: Line 564: if (host != null) { Line 565: // Get the values of the timeouts: Line 566: int clientTimeOut = Config.<Integer> getValue(ConfigValues.vdsTimeout) * 1000; Line 567: int connectionTimeOut = Config.<Integer> getValue(ConfigValues.vdsConnectionTimeout) * 1000; Line 568: int heartBeat = Config.<Integer> getValue(ConfigValues.vdsHeartbeat) * 1000; > As specified in the protocol spec [1] the value needs to be in miliseconds. ok, it will be nice if this can be mentioned as a comment somewhere. or maybe even change int heartBeat to int HeartBeatInMiliSeconds :) Line 569: int clientRetries = Config.<Integer> getValue(ConfigValues.vdsRetries); Line 570: irsProxy = TransportFactory.createIrsServer(getProtocol(), host, getmIrsPort(), clientTimeOut, connectionTimeOut, clientRetries, heartBeat); Line 571: runStoragePoolUpEvent(storagePool); Line 572: } -- To view, visit http://gerrit.ovirt.org/30165 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9e8a20592542ce1a754dee1917ff9ebba6b8daf9 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Barak Azulay <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
