Alon Bar-Lev has posted comments on this change. Change subject: aaa: more fixes to sync and usages ......................................................................
Patch Set 3: (1 comment) http://gerrit.ovirt.org/#/c/30473/3/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddUserCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddUserCommand.java: Line 46 Line 47 Line 48 Line 49 Line 50 this is so unexpected that add performs update! I suggest minor change: DbUser user = getParameters().getUserToAdd(); // assume we going to use this DbUser syncResult = SyncUsers.sync(user); user = syncResult != null ? syncResult : user; -- To view, visit http://gerrit.ovirt.org/30473 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0d6198409b7c3e66054716e1abdfcd06e8dd204d Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
