Yair Zaslavsky has posted comments on this change. Change subject: aaa: more fixes to sync and usages ......................................................................
Patch Set 3: (2 comments) http://gerrit.ovirt.org/#/c/30473/3/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddUserCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddUserCommand.java: Line 46 Line 47 Line 48 Line 49 Line 50 > this is so unexpected that add performs update! I suggest minor change: I agree but this is the original functionality. and isnt your suggestion quite equivalent to what I suggested? (maybe except for naming issues?) http://gerrit.ovirt.org/#/c/30473/3/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SyncUsers.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SyncUsers.java: Line 66: DbUser activeUser = activeUsers.get(dbUser.getExternalId()); Line 67: if (activeUser != null) { Line 68: if (!activeUser.equals(dbUser)) { Line 69: activeUser.setId(dbUser.getId()); Line 70: log.info(String.format("The user %1$s from authz extension %2$s got synchronized with the matching user persistent at oVirt-engine database", > I think the message should be rolledback, this function has nothing to do w I didn't like the "last interval" part. it's not being used only for periodic sync. Hmm, how about "The user %1$s from authz extension %2$s got synchronized" Line 71: activeUser.getLoginName(), Line 72: activeUser.getDomain())); Line 73: usersToUpdate.add(activeUser); Line 74: } -- To view, visit http://gerrit.ovirt.org/30473 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0d6198409b7c3e66054716e1abdfcd06e8dd204d Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
