Moti Asayag has posted comments on this change. Change subject: webadmin: Allow custom properties on NIC without network ......................................................................
Patch Set 1: (1 comment) what about removing the message from backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties and frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties ? http://gerrit.ovirt.org/#/c/30108/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/SetupNetworksHelper.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/SetupNetworksHelper.java: Line 157: Set<String> newLabels = NetworkUtils.isLabeled(nic) ? nic.getLabels() : Collections.<String> emptySet(); Line 158: Set<String> existingLabels = Line 159: NetworkUtils.isLabeled(existingNic) ? existingNic.getLabels() : Collections.<String> emptySet(); Line 160: if (!CollectionUtils.isEqualCollection(newLabels, existingLabels) Line 161: || (!StringUtils.isEmpty(nic.getNetworkName()) && qosOrCustomPropertiesChanged(nic, existingNic))) { shouldn't it be StringUtils.isNotEmpty(...) ? Line 162: existingNic.setLabels(newLabels); Line 163: existingNic.setQosOverridden(nic.isQosOverridden()); Line 164: existingNic.setCustomProperties(nic.getCustomProperties()); Line 165: modifiedInterfaces.add(existingNic); -- To view, visit http://gerrit.ovirt.org/30108 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibded6b7b7ffe9be960d522bd63cbf9db08b18d6e Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <[email protected]> Gerrit-Reviewer: Lior Vernia <[email protected]> Gerrit-Reviewer: Martin Mucha <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: Yevgeny Zaspitsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
