Moti Asayag has posted comments on this change. Change subject: webadmin: Allow custom properties on NIC without network ......................................................................
Patch Set 3: Code-Review+2 (1 comment) minor comment inside http://gerrit.ovirt.org/#/c/30108/3/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/SetupNetworksHelper.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/SetupNetworksHelper.java: Line 273: Map<String, String> validPropertiesNonVm = new HashMap<String, String>(validProperties); Line 274: validPropertiesNonVm.remove("bridge_opts"); Line 275: for (VdsNetworkInterface iface : params.getInterfaces()) { Line 276: String networkName = iface.getNetworkName(); Line 277: if (iface.hasCustomProperties() && !StringUtils.isEmpty(networkName)) { should also be StringUtils.isNotEmpty()) Line 278: if (!networkCustomPropertiesSupported) { Line 279: addViolation(VdcBllMessages.ACTION_TYPE_FAILED_NETWORK_CUSTOM_PROPERTIES_NOT_SUPPORTED, networkName); Line 280: } Line 281: -- To view, visit http://gerrit.ovirt.org/30108 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibded6b7b7ffe9be960d522bd63cbf9db08b18d6e Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <[email protected]> Gerrit-Reviewer: Lior Vernia <[email protected]> Gerrit-Reviewer: Martin Mucha <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: Yevgeny Zaspitsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
