Michael Kublin has posted comments on this change. Change subject: [WIP] core: Refactor AsyncTaskManager.createTask ......................................................................
Patch Set 2: (1 inline comment) .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java Line 1053: retValue = (task != null) ? task.getTaskID() : null; no need check for null, task will be usually created, if it is not we have a bug and these should be solved -- To view, visit http://gerrit.ovirt.org/5986 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia820fd378331b1360cb2766feda80d8c2878310e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Michael Kublin <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
