Maor Lipchuk has posted comments on this change.
Change subject: [WIP] core: Refactor AsyncTaskManager
......................................................................
Patch Set 6: I would prefer that you didn't submit this
(3 inline comments)
Compilation fail - using save in AsyncTaskUtils does not apply to the API in
the AsyncTaskDAO
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AsyncTaskManager.java
Line 394: "AsyncTaskManager::addTaskToManager: Adding
task '{0}' (Parent Command {1}, Parameters Type {2}), {3}.",
I think AsyncTaskManager::addTaskToManager: in the log is redundant, it doesn't
really help in the logs and just add maintenance to the code.
Line 409: "AsyncTaskManager::addTaskToManager: Task
'{0}' already exists with action type 'Unknown', now overriding it with action
type '{1}'",
I think AsyncTaskManager::addTaskToManager: in the log is redundant, it doesn't
really help in the logs and just add maintenance to the code.
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/AsyncTaskUtils.java
Line 42:
DbFacade.getInstance().getAsyncTaskDAO().save(asyncTask.getParameters().getDbAsyncTask(),asyncTask.getEntityType(),asyncTask.getAssociatedEntities());
AsyncTaskDAO save only support async_tasks as a parameter.
--
To view, visit http://gerrit.ovirt.org/5986
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia820fd378331b1360cb2766feda80d8c2878310e
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Michael Kublin <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
