Nir Soffer has posted comments on this change. Change subject: core: unlock_entity.sh fails on authentication ......................................................................
Patch Set 2: (2 comments) http://gerrit.ovirt.org/#/c/30568/2/packaging/dbscripts/unlock_entity.sh File packaging/dbscripts/unlock_entity.sh: Line 25: -q - Query db and display a list of the locked entites. Line 26: ENTITIES - The list of object names in case of vm/template, UUIDs in case of a disk Line 27: Line 28: NOTE: This utility access the database and should have the corresponding credentals. Line 29: In case that a password is used to access the database PGPASSWORD or PGPASSFILE should be set. > double space I mean between or and PGPASSFILE :)))) I would also wrap the lines at 72 characters, for better readability. Line 30: Example: Line 31: $PGPASSWORD=xxxxxx ./unlock_entity.sh -u engine -t disk -q Line 32: Line 33: __EOF__ Line 27: Line 28: NOTE: This utility access the database and should have the corresponding credentals. Line 29: In case that a password is used to access the database PGPASSWORD or PGPASSFILE should be set. Line 30: Example: Line 31: $PGPASSWORD=xxxxxx ./unlock_entity.sh -u engine -t disk -q And indent the example: Example: $ PGPASSWORD=xxxxxx ./unlock_entity.sh -t disk -q Since engine is the default value for -u, there is no need to show it in the example. Line 32: Line 33: __EOF__ Line 34: } Line 35: -- To view, visit http://gerrit.ovirt.org/30568 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6055bec6b91d5eb101e6655ed4eea481a6a082f9 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
