Eli Mesika has posted comments on this change. Change subject: core: unlock_entity.sh fails on authentication ......................................................................
Patch Set 4: (3 comments) http://gerrit.ovirt.org/#/c/30568/4//COMMIT_MSG Commit Message: Line 11: PGPASSWORD or PGPASSFILE environment variable. Line 12: Line 13: Example: Line 14: Line 15: >PGPASSWORD=xxxxxx ./unlock_entity.sh -u engine -t disk -q > Please update this line to match the online help, or just remove the exampl Done Line 16: Line 17: I had added this information to the utility help Line 18: Line 19: Change-Id: I6055bec6b91d5eb101e6655ed4eea481a6a082f9 http://gerrit.ovirt.org/#/c/30568/4/packaging/dbscripts/unlock_entity.sh File packaging/dbscripts/unlock_entity.sh: Line 27: Line 28: NOTE: This utility access the database and should have the Line 29: corresponding credentals. Line 30: In case that a password is used to access the database PGPASSWORD Line 31: or PGPASSFILE should be set. > We need more whitespace - empty line between paragraphs helps to read stuff Done Line 32: Example: Line 33: \$ PGPASSWORD=xxxxxx ./unlock_entity.sh -t disk -q Line 34: __EOF__ Line 35: } Line 28: NOTE: This utility access the database and should have the Line 29: corresponding credentals. Line 30: In case that a password is used to access the database PGPASSWORD Line 31: or PGPASSFILE should be set. Line 32: Example: > Empty line around example code helps too. Done Line 33: \$ PGPASSWORD=xxxxxx ./unlock_entity.sh -t disk -q Line 34: __EOF__ Line 35: } Line 36: -- To view, visit http://gerrit.ovirt.org/30568 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6055bec6b91d5eb101e6655ed4eea481a6a082f9 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
