Maor Lipchuk has posted comments on this change.
Change subject: core: RegisterVdsQuery -removed CanDoAction()
......................................................................
Patch Set 5: (2 inline comments)
Looks good, minor comments
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RegisterVdsQuery.java
Line 130: log.error("RegisterVdsQuery::CanDoAction: An exception
has been thrown.", ex);
RegisterVdsQuery::CanDoAction is redundant, I think you can simply remove them.
....................................................
Commit Message
Line 10: validatins which were moved to validateInputes() method.
Please change validatins to validations
--
To view, visit http://gerrit.ovirt.org/5631
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6c33cc1af4127da44fecd74559124090a535f574
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Doron Fediuck <[email protected]>
Gerrit-Reviewer: Liron Aravot <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Michael Kublin <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
