Allon Mureinik has posted comments on this change.
Change subject: core: RegisterVdsQuery -removed CanDoAction()
......................................................................
Patch Set 7: I would prefer that you didn't submit this
(3 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RegisterVdsQuery.java
Line 107: if (StringUtils.isBlank(hostName)) {
You meant to use StringUtils.isEmpty(). isBlank returns true for a string made
up of whitespaces too.
Line 123: if (otp != null && !isValidOtp(vds, otp)) {
isValidOtp already checks otp for null - don't have to check it twice.
Line 202: if (StringUtils.isBlank(getParameters().getVdsName())) {
s/isBlank/isEmpty/
--
To view, visit http://gerrit.ovirt.org/5631
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6c33cc1af4127da44fecd74559124090a535f574
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Doron Fediuck <[email protected]>
Gerrit-Reviewer: Liron Aravot <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Michael Kublin <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
