Jiří Moskovčák has posted comments on this change. Change subject: don't die when broker disconnects ......................................................................
Patch Set 3: -Verified (1 comment) http://gerrit.ovirt.org/#/c/30114/3/ovirt_hosted_engine_ha/agent/agent.py File ovirt_hosted_engine_ha/agent/agent.py: Line 171: except Exception as e: Line 172: self._log.error("Error: '{0}' - trying to restart agent" Line 173: .format(str(e))) Line 174: Line 175: attempt += 1 > no need to increase attempt in a for loop oh, it's even worse, I must not increase it :) fixing.. Line 176: time.sleep(constants.AGENT_START_RETRY_WAIT) Line 177: self._log.warn("Restarting agent, attempt '{0}'".format(attempt)) Line 178: else: Line 179: self._log.error("Too many errors occurred, giving up. " -- To view, visit http://gerrit.ovirt.org/30114 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibd8627346c03894c1654af5d41c3caaf9f3a5ffa Gerrit-PatchSet: 3 Gerrit-Project: ovirt-hosted-engine-ha Gerrit-Branch: master Gerrit-Owner: Jiří Moskovčák <[email protected]> Gerrit-Reviewer: Jiří Moskovčák <[email protected]> Gerrit-Reviewer: Martin Sivák <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
