Martin Sivák has posted comments on this change. Change subject: don't die when broker disconnects ......................................................................
Patch Set 4: (1 comment) http://gerrit.ovirt.org/#/c/30114/4/ovirt_hosted_engine_ha/lib/brokerlink.py File ovirt_hosted_engine_ha/lib/brokerlink.py: Line 38: def __init__(self): Line 39: self._log = logging.getLogger("%s.BrokerLink" % __name__) Line 40: self._socket = None Line 41: Line 42: def connect(self, retries=0, wait=5): What about using the constant declared elsewhere as the default value? Line 43: """ Line 44: Connect to the HA Broker. Upon failure, reconnection attempts will Line 45: be made approximately once per second until the specified number of Line 46: retries have been made. An exception will be raised if a connection -- To view, visit http://gerrit.ovirt.org/30114 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibd8627346c03894c1654af5d41c3caaf9f3a5ffa Gerrit-PatchSet: 4 Gerrit-Project: ovirt-hosted-engine-ha Gerrit-Branch: master Gerrit-Owner: Jiří Moskovčák <[email protected]> Gerrit-Reviewer: Jiří Moskovčák <[email protected]> Gerrit-Reviewer: Martin Sivák <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
