Yair Zaslavsky has posted comments on this change. Change subject: core: add host_provider_id to vdsStatic ......................................................................
Patch Set 5: (2 comments) http://gerrit.ovirt.org/#/c/30059/5/backend/manager/modules/dal/src/test/resources/fixtures.xml File backend/manager/modules/dal/src/test/resources/fixtures.xml: Line 1325: <value>22</value> Line 1326: <value>root</value> Line 1327: <value>1</value> Line 1328: <value>0</value> Line 1329: <null /> if we have a provider table, maybe worth placing some of its guids here instead of just null? Line 1330: </row> Line 1331: <row> Line 1332: <value>afce7a39-8e8c-4819-ba9c-796d316592e7</value> Line 1333: <value>purple-vdsc</value> http://gerrit.ovirt.org/#/c/30059/5/packaging/dbscripts/upgrade/03_05_0760_add_provider_host_id_vdsstatic.sql File packaging/dbscripts/upgrade/03_05_0760_add_provider_host_id_vdsstatic.sql: Line 1: select fn_db_add_column('vds_static', 'host_provider_id', 'UUID'); Line 2: CONSTRAINT fk_vds_static_host_provider_id FOREIGN KEY (host_provider_id) REFERENCES providers(id) ON DELETE SET NULL script numbering is wrong - master is 03_06 .. ovirt-engine-3.5 is 03_05 -- To view, visit http://gerrit.ovirt.org/30059 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icced7dda43fee83aa904a068cff48b1fd3da4b76 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
