Alon Bar-Lev has posted comments on this change. Change subject: aaa: Adding namespace dropdown list to "add user" dialog ......................................................................
Patch Set 4: (1 comment) http://gerrit.ovirt.org/#/c/30698/4/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java: Line 1217: { Line 1218: return source != null ? (HashMap<String, List<String>>) source : new HashMap<String, List<String>>(); Line 1219: } Line 1220: }; Line 1221: Frontend.getInstance().runQuery(VdcQueryType.GetAvailableNamespaces, new VdcQueryParametersBase(), aQuery); > Right, but i would prefer not to mix between the two. well, I we have duplicate entries in profiles list... why not return the name space as well? profile1 authz1 namespace1 namespace2 namespace3 profile2 authz1 namespace1 namespace2 namespace3 not that important... just roundtrip of new query Line 1222: } Line 1223: Line 1224: Line 1225: public void getAAAProfilesEntriesList(AsyncQuery aQuery) { -- To view, visit http://gerrit.ovirt.org/30698 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic78559243c765271bf8e12abd035deba05226bda Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Alona Kaplan <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
