Yair Zaslavsky has posted comments on this change. Change subject: aaa: Adding namespace dropdown list to "add user" dialog ......................................................................
Patch Set 4: (4 comments) http://gerrit.ovirt.org/#/c/30698/4/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetAvailableNamespacesQuery.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetAvailableNamespacesQuery.java: Line 10: import org.ovirt.engine.core.extensions.mgr.ExtensionProxy; Line 11: import org.ovirt.engine.core.utils.collections.MultiValueMapUtils; Line 12: import org.ovirt.engine.core.utils.extensionsmgr.EngineExtensionsManager; Line 13: Line 14: public class GetAvailableNamespacesQuery<P extends VdcQueryParametersBase> extends QueriesCommandBase<P> { > why don't you just return this information within the get authz list existi Well, this query is used in other places as well, i would prefer not to alter it. Line 15: Line 16: public GetAvailableNamespacesQuery(P parameters) { Line 17: super(parameters); Line 18: } Line 20: @Override Line 21: protected void executeQueryCommand() { Line 22: HashMap<String, List<String>> namespacesMap = new HashMap<>(); Line 23: for (ExtensionProxy authz: EngineExtensionsManager.getInstance().getExtensionsByService(Authz.class.getName())) { Line 24: for (String namespace : authz.getContext().get(Authz.ContextKeys.AVAILABLE_NAMESPACES, Arrays.asList("*"))) { > no need for default, there cannot be a provider without namespace. hmm, i see InternalAuthz does not return AVAILABLE_NAMESPACES.... i will fix that and remove the defaults. Line 25: MultiValueMapUtils.addToMap(AuthzUtils.getName(authz), namespace, namespacesMap); Line 26: Line 27: } Line 28: } http://gerrit.ovirt.org/#/c/30698/4/backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/aaa/BackendDomainUsersResource.java File backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/aaa/BackendDomainUsersResource.java: Line 49: } Line 50: Line 51: @Override Line 52: protected SearchParameters createSearchParameters(SearchType searchType, String constraint) { Line 53: return new DirectorySearchParameters(constraint, searchType, "*"); > there cannot be a query without namespace '*' is not a default yes, this means that the rest-api should be fixed to support all namespaces. Line 54: } Line 55: Line 56: @Override Line 57: @SingleEntityResource http://gerrit.ovirt.org/#/c/30698/4/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java: Line 1217: { Line 1218: return source != null ? (HashMap<String, List<String>>) source : new HashMap<String, List<String>>(); Line 1219: } Line 1220: }; Line 1221: Frontend.getInstance().runQuery(VdcQueryType.GetAvailableNamespaces, new VdcQueryParametersBase(), aQuery); > any reason why not GetAAAProfileList should return namespaces for each prof Right, but i would prefer not to mix between the two. In addition, correct me if i'm wrong but namespace is a "per authz" term, and not per profile, no? Line 1222: } Line 1223: Line 1224: Line 1225: public void getAAAProfilesEntriesList(AsyncQuery aQuery) { -- To view, visit http://gerrit.ovirt.org/30698 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic78559243c765271bf8e12abd035deba05226bda Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Alona Kaplan <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
