Michael Kublin has uploaded a new change for review. Change subject: core: Removing very bad code ......................................................................
core: Removing very bad code I will not explain why I removed a following code, I think it obvious, but I will provide an issues which were solved only by small clean up: 1. Using a wrong API at IrsBrokerCommand, instead of doing some logic a log message was written 2. Removed unneeded ejb look ups at *VDSCommand, small performance improvement 3. Removed statless been cache - should improve so many things: performance, memory, reduce load on jboss, etc... (By the way in java 1.4 sometimes was used J2EE pattern for caching statefull bean but statless) Change-Id: I5420f7446c8e2b0d082e2ca6f1a0c54432321fd0 Signed-off-by: Michael Kublin <[email protected]> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VDSBrokerFrontendImpl.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsEventListener.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/CreateVmVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/MigrateVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/ResourceManager.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/ResumeVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsBrokerCommand.java 7 files changed, 28 insertions(+), 181 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/97/6097/1 -- To view, visit http://gerrit.ovirt.org/6097 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I5420f7446c8e2b0d082e2ca6f1a0c54432321fd0 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Kublin <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
