Michael Kublin has posted comments on this change.
Change subject: core: Removing very bad code
......................................................................
Patch Set 1: (3 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VDSBrokerFrontendImpl.java
Line 47: if (!StringUtils.isEmpty(result.getExceptionString())) {
ok
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsBrokerCommand.java
Line 770:
ResourceManager.getInstance().getEventListener().storagePoolStatusChanged(storagePool.getId(),
storagePool.getstatus());
I run and it passed our formatter plug in check and compilation, I will try
again but can not promised anything
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/ResourceManager.java
Line 110: private final ConcurrentHashMap<Guid, Boolean> _asyncRunningVms =
I wait for that question, in java we have not ConcurrentHashSet only at some
third party packages, the only way to create is Collections.newSetFromMap(new
ConcurrentHashMap<Object,Boolean>()), what for? By the way a regular HashSet is
based on HashMap, but it is more logical to use a HashSet, but if I have not
special class, I prefer to use something that more suitable for me.
--
To view, visit http://gerrit.ovirt.org/6097
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5420f7446c8e2b0d082e2ca6f1a0c54432321fd0
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Michael Kublin <[email protected]>
Gerrit-Reviewer: Michael Kublin <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
