Maor Lipchuk has posted comments on this change.
Change subject: [WIP] core: Refactoring AsyncTaskManager
......................................................................
Patch Set 13: Looks good to me, but someone else must approve
(3 inline comments)
See inline comments
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateSnapshotCommand.java
Line 141: //
DbFacade.Instance.GetVmByImageId(DiskImage.image_guid).vm_guid),
Consider removing this comment, I don't see how it is related to this method
....................................................
File
backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/AsyncTaskDAOTest.java
Line 29: private static final Guid ENTITY_WITH_TASKS_ID =
Guid.createGuidFromString("72e3a666-89e1-4005-a7ca-f7548004a9ab");
No need to use it, since there is a constant on the FixturesTool for this Guid
....................................................
File
backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/FixturesTool.java
Line 180: protected static final Guid ENTITY_WITH_TASKS_ID = new
Guid("72e3a666-89e1-4005-a7ca-f7548004a9ab");
There is already a constant in the fixturesTool for this guid
STORAGE_DOAMIN_SCALE_SD5
--
To view, visit http://gerrit.ovirt.org/5986
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia820fd378331b1360cb2766feda80d8c2878310e
Gerrit-PatchSet: 13
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Michael Kublin <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
