Maor Lipchuk has posted comments on this change.
Change subject: [WIP] core: Refactoring AsyncTaskManager
......................................................................
Patch Set 12: (6 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AsyncTaskManager.java
Line 394: "AsyncTaskManager::addTaskToManager: Adding
task '{0}' (Parent Command {1}, Parameters Type {2}), {3}.",
Please remove AsyncTaskManager::addTaskToManager:
Line 409: "AsyncTaskManager::addTaskToManager: Task
'{0}' already exists with action type 'Unknown', now overriding it with action
type '{1}'",
Please remove AsyncTaskManager::addTaskToManager:
Line 546: AsyncTaskUtils.saveAsyncTaskInDB(task);
If you will have the task already in the DB, why save it again?
Isn't it will create sql exception? if engine will be restarted?
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java
Line 1100: protected SPMAsyncTask ConcreteCreateTask(AsyncTaskCreationInfo
asyncTaskCreationInfo, VdcActionType parentCommand) {
If you already change the method return value maybe consider to change the
method name to be valid (ConcreteCreateTask -> concreteCreateTask)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/AsyncTaskUtils.java
Line 22:
log.infoFormat("BaseAsyncTask::AddOrUpdateTaskInDB: Adding task {0} to
DataBase",
Please remove BaseAsyncTask::AddOrUpdateTaskInDB:
Line 31: "BaseAsyncTask::AddOrUpdateTaskInDB:
Adding/Updating task %1$s to DataBase threw an exception.",
Please remove BaseAsyncTask::AddOrUpdateTaskInDB:
--
To view, visit http://gerrit.ovirt.org/5986
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia820fd378331b1360cb2766feda80d8c2878310e
Gerrit-PatchSet: 12
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Michael Kublin <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
