Doron Fediuck has posted comments on this change.

Change subject: tools: engine-config bug fixes
......................................................................


Patch Set 4: (1 inline comment)

Shahar, I think you missed a mod.
See inline.

....................................................
File 
backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/kerberos/ConfigurationProvider.java
Line 68:             Runtime.getRuntime().exec("/usr/bin/chmod " + filePath);
chmod to what??? which mask are you using?

Also, is there no way to do this in Java?
See setReadable: 
http://java.sun.com/developer/technicalArticles/J2SE/Desktop/javase6/enhancements/

--
To view, visit http://gerrit.ovirt.org/6096
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3003f20a51bb5a62387593d914894d62b012c70b
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <[email protected]>
Gerrit-Reviewer: Doron Fediuck <[email protected]>
Gerrit-Reviewer: Juan Hernandez <[email protected]>
Gerrit-Reviewer: Shahar Havivi <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to