Juan Hernandez has posted comments on this change.
Change subject: tools: engine-config bug fixes
......................................................................
Patch Set 8: (3 inline comments)
I verified this with a new build. It works mostly correct, but I found an issue
with the interactive option, it has to be exactly "Interactive", as the
comparison in the code is case sensitive.
The password file is generated with the right permissions (chmod works) and it
is removed after use.
....................................................
File
backend/manager/tools/engine-config/src/main/java/org/ovirt/engine/core/config/entity/helper/PasswordValueHelper.java
Line 21: private static final Logger log =
Logger.getLogger(PasswordValueHelper.class);
Be aware of the upercase "I" here.
Line 88: if (StringUtils.isNotBlank(value) &&
value.equals(INTERACTIVE_MODE)) {
If you use "equalsIgnoreCase" instead of "equals" here it will be more user
friendly.
Line 112: if (StringUtils.isNotBlank(value) &&
value.equals(INTERACTIVE_MODE)) {
Use "equalsIgnoreCase" here.
--
To view, visit http://gerrit.ovirt.org/6096
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3003f20a51bb5a62387593d914894d62b012c70b
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <[email protected]>
Gerrit-Reviewer: Doron Fediuck <[email protected]>
Gerrit-Reviewer: Juan Hernandez <[email protected]>
Gerrit-Reviewer: Shahar Havivi <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
