Alon Bar-Lev has posted comments on this change. Change subject: engine, webadmin: Webadmin read reports.xml from remote reports app ......................................................................
Patch Set 23: (3 comments) minor comments... http://gerrit.ovirt.org/#/c/29723/23/backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/servlet/RedirectServlet.java File backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/servlet/RedirectServlet.java: Line 48: url += "&"; Line 49: } Line 50: url += queryString; Line 51: } Line 52: response.sendRedirect(response.encodeRedirectURL(url)); I am almost sure you cannot encode the query string, as result is double encode. Line 53: } http://gerrit.ovirt.org/#/c/29723/23/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/ReportInit.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/ReportInit.java: Line 27: private static final int MAX_RETRY_COUNTS = 20; Line 28: private static final int RETRY_INTERVAL = 30000; Line 29: public static final String ReportRedirectService = "services/reports-redirect"; //$NON-NLS-1$ Line 30: public static final String ReportStatusService = "services/reports-proxy?command=status"; //$NON-NLS-1$ Line 31: public static final String ReportXmlService = "services/reports-proxy?command=webadmin-ui-xml"; //$NON-NLS-1$ reports-interface-proxy - see next comment... by convention, the servlet name should be the same with -proxy suffix, so people can guess from the url what is called... Line 32: private int retryCount; Line 33: private boolean reportsWebappDeployed; Line 34: private boolean scheduledStatusCheckInProgress; Line 35: private boolean reportsEnabled; http://gerrit.ovirt.org/#/c/29723/23/packaging/services/ovirt-engine/ovirt-engine.conf.in File packaging/services/ovirt-engine/ovirt-engine.conf.in: Line 215: # by default serv 404. Line 216: # Line 217: ENGINE_REPORTS_BASE_URL= Line 218: ENGINE_REPORTS_DASHBOARD_URL=${ENGINE_REPORTS_BASE_URL}/flow.html?viewAsDashboardFrame=true Line 219: ENGINE_REPORTS_PROXY_URL=${ENGINE_REPORTS_BASE_URL}/ReportsProxy I would like this to be within ${ENGINE_REPORTS_BASE_URL}/ovirt/reports-interface or similar if we can... so we have explicit namespace for our resources. Line 220: Line 221: -- To view, visit http://gerrit.ovirt.org/29723 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I76db7ab889f21de083bb3c8276e8abb77b68fdb3 Gerrit-PatchSet: 23 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Alona Kaplan <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Ravi Nori <[email protected]> Gerrit-Reviewer: Shirly Radco <[email protected]> Gerrit-Reviewer: Yaniv Dary <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
