Ravi Nori has posted comments on this change. Change subject: engine, webadmin: Webadmin read reports.xml from remote reports app ......................................................................
Patch Set 23: (1 comment) http://gerrit.ovirt.org/#/c/29723/23/packaging/services/ovirt-engine/ovirt-engine.conf.in File packaging/services/ovirt-engine/ovirt-engine.conf.in: Line 215: # by default serv 404. Line 216: # Line 217: ENGINE_REPORTS_BASE_URL= Line 218: ENGINE_REPORTS_DASHBOARD_URL=${ENGINE_REPORTS_BASE_URL}/flow.html?viewAsDashboardFrame=true Line 219: ENGINE_REPORTS_PROXY_URL=${ENGINE_REPORTS_BASE_URL}/ReportsProxy > I would like this to be within ${ENGINE_REPORTS_BASE_URL}/ovirt/reports-int The reports base url is going to be https://127.0.0.1:8453/ovirt-engine-reports so I think the below should be fine, please let me know if you think it should be different ENGINE_REPORTS_PROXY_URL=${ENGINE_REPORTS_BASE_URL}/reports-interface Line 220: Line 221: -- To view, visit http://gerrit.ovirt.org/29723 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I76db7ab889f21de083bb3c8276e8abb77b68fdb3 Gerrit-PatchSet: 23 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Alona Kaplan <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Ravi Nori <[email protected]> Gerrit-Reviewer: Shirly Radco <[email protected]> Gerrit-Reviewer: Yaniv Dary <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
