Omer Frenkel has posted comments on this change.

Change subject: engine: Removing HandleFailedStorageDomainCommand
......................................................................


Patch Set 2:

there is a difference between calling reconstruct from 
HandleFailedStorageDomainCommand and VdsEventListener.masterDomainNotOperational
the first send "isInactive = true" and the seconds send false there, it will 
cause all the other hosts to stay connected to the old domain, not sure if 
problematic or not, please verify its not a problem

--
To view, visit http://gerrit.ovirt.org/6179
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I61e1674056f9060440989d70516109dd5ee37f9a
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Michael Kublin <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Michael Kublin <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to