Ayal Baron has posted comments on this change. Change subject: engine: Removing HandleFailedStorageDomainCommand ......................................................................
Patch Set 2: I would prefer that you didn't submit this (5 inline comments) .................................................... File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsBrokerCommand.java Line 1339: .getEventListener().masterDomainNotOperational(domainId, _storagePoolId); Omer is correct, need to set inactive to true. .................................................... Commit Message Line 9: The following command is removed because of it was used only at one place: s/of// s/at/in/ Line 10: VdsEventListener.storageDomainNotOperational, the logic of command was: s/,/./ Line 11: if domain is master run reconstruct, otherwise run deactivate storage domain. s/master/master,/ Line 14: otherwise VdsEventListener.storageDomainNotOperational, so no need to duplicate a logic s/a/the/ -- To view, visit http://gerrit.ovirt.org/6179 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I61e1674056f9060440989d70516109dd5ee37f9a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Kublin <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Ayal Baron <[email protected]> Gerrit-Reviewer: Michael Kublin <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
