Juan Hernandez has posted comments on this change.
Change subject: packaging: Run with OpenJDK 7 regardless of what is installed
......................................................................
Patch Set 1: (2 inline comments)
....................................................
File packaging/fedora/engine-service.py
Line 109: javaHomeDir = getSysconfig("JAVA_HOME",
"/usr/lib/jvm/java-1.7.0-openjdk.x86_64")
Using just "java" is exactly what we wan't to avoid. That means that any change
by the user with the alternatives commands, or any new JDK that is installed
will affect an probably break the engine the next time it is restarted.
We already have a service configuration file /etc/sysconfig/ovirt-engine where
these service parameters should go. Maybe it is not perfect, maybe it should be
relocated, but I don't see any reason to create another one.
I know that using a hardcoded path is not nice, but it solves the problem we
have at the moment. Ideally we should lookup the rigth version in the setup
tool and write it to the configuration file, but that belongs in a different
and larger change.
We can't use whatever vendor, the only one we tested is OpenJDK, and we know
that others, for example IBM J9, fail, that is why we are doing this change.
Line 109: javaHomeDir = getSysconfig("JAVA_HOME",
"/usr/lib/jvm/java-1.7.0-openjdk.x86_64")
/etc/alternatives is not a solution, in fact it is the source of the problem:
when you use "java" you are using whatever the administrator of the machine
decided to select, and that can be Sun Java 6, IBM J9 Java 7, gcj, who knows.
We already had situations where this broke the engine, in particular with IBM
J9.
--
To view, visit http://gerrit.ovirt.org/6223
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I44b5b4e20a134d1624acf1258c59b73d8d2382c6
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Juan Hernandez <[email protected]>
Gerrit-Reviewer: Moran Goldboim <[email protected]>
Gerrit-Reviewer: Ofer Schreiber <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
