Roy Golan has posted comments on this change.
Change subject: packaging: Run with OpenJDK 7 regardless of what is installed
......................................................................
Patch Set 1: Looks good to me, but someone else must approve
(1 inline comment)
....................................................
File packaging/fedora/engine-service.py
Line 109: javaHomeDir = getSysconfig("JAVA_HOME",
"/usr/lib/jvm/java-1.7.0-openjdk.x86_64")
The solution is ok and is using the standard JAVA_HOME variable. minor thing is
JAVA_HOME set in the user env is overwritten by reading the
/etc/sysconfig/ovirt-engine
--
To view, visit http://gerrit.ovirt.org/6223
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I44b5b4e20a134d1624acf1258c59b73d8d2382c6
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Juan Hernandez <[email protected]>
Gerrit-Reviewer: Moran Goldboim <[email protected]>
Gerrit-Reviewer: Ofer Schreiber <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
