Mike Kolesnik has posted comments on this change.
Change subject: engine: importing cloned VM cause invalid audit log: 'Mac
address is in use...'
......................................................................
Patch Set 1: I would prefer that you didn't submit this
(4 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java
Line 149: // we allocate new Mac in Execute() via
VmInterfaceManager.add() method
I'm not sure if putting this comment here is interesting..
You can see this was deleted in git log and the commit message, so I'm not sure
this provides any useful information.
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/VmInterfaceManager.java
Line 37: public boolean add(VmNetworkInterface iface, CompensationContext
compensationContext, boolean allocateMac) {
You added a parameter but this command is also used from other places, so this
will cause compilation failures.
Line 46:
iface.setMacAddress(MacPoolManager.getInstance().allocateNewMac());
Please add a test to VmInterfaceManagerTest to cover this new code path
Line 48: macAdded =
getMacPoolManager().AddMac(iface.getMacAddress());
This will now always return false if you asked to allocate the MAC, which will
cause problems later on.
--
To view, visit http://gerrit.ovirt.org/6324
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7d4fac78bba4e6a70afd01b7cc122c580b346dcc
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Mike Kolesnik <[email protected]>
Gerrit-Reviewer: Shahar Havivi <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
