Shahar Havivi has posted comments on this change.
Change subject: engine: importing cloned VM cause invalid audit log: 'Mac
address is in use...'
......................................................................
Patch Set 1: (4 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java
Line 149: // we allocate new Mac in Execute() via
VmInterfaceManager.add() method
Done
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/VmInterfaceManager.java
Line 37: public boolean add(VmNetworkInterface iface, CompensationContext
compensationContext, boolean allocateMac) {
No other uses that I saw, and I did compile the code... (hence the +1 verify
flag)
Line 46:
iface.setMacAddress(MacPoolManager.getInstance().allocateNewMac());
Done
Line 48: macAdded =
getMacPoolManager().AddMac(iface.getMacAddress());
we can set it to true in the allocateMac case but I am not sure that is the
right action...
--
To view, visit http://gerrit.ovirt.org/6324
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7d4fac78bba4e6a70afd01b7cc122c580b346dcc
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Mike Kolesnik <[email protected]>
Gerrit-Reviewer: Shahar Havivi <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
