Allon Mureinik has posted comments on this change.

Change subject: core, db: add logical_name to vm_device
......................................................................


Patch Set 2: Code-Review+1

(1 comment)

Please see minor suggestion in fixtures.xml

http://gerrit.ovirt.org/#/c/31754/2/backend/manager/modules/dal/src/test/resources/fixtures.xml
File backend/manager/modules/dal/src/test/resources/fixtures.xml:

Line 5721:             <value>false</value>
Line 5722:             <value>alias</value>
Line 5723:             <value>{ "prop1" : "true", "prop2" : "123456" }</value>
Line 5724:             <null />
Line 5725:             <null />
Please have at least one entry with data for the logical_name
Line 5726:         </row>
Line 5727: 
Line 5728:         <row>
Line 5729:             <value>1b26a52b-b60f-44cb-9f46-3ef333b04a35</value>


-- 
To view, visit http://gerrit.ovirt.org/31754
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If9b5a8e771a05c1fe44834adfe998cf921f6ae52
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to