Alon Bar-Lev has posted comments on this change. Change subject: database: do not use git when building ......................................................................
Patch Set 1: (1 inline comment) .................................................... File backend/manager/dbscripts/check_for_duplicate_upgrade_scripts.sh Line 1: #!/bin/sh I don't see any reason to use bash if we use POSIX and do not use any feature of bash. Quite common, there is no reason to use bash unless there is actual need. -- To view, visit http://gerrit.ovirt.org/6255 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If06ea52efb4da7c51dad8fc2b32043082ce13263 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Moran Goldboim <mgold...@redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschr...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
