Alon Bar-Lev has posted comments on this change. Change subject: database: do not use git when building ......................................................................
Patch Set 1: >>> From: Eli Mesika Jul 17 >>> Since we are using bash in all our scripts , please write #!/bin/bash >>> no other changes are needed , I had tested it and it works >> From: Alon Bar-Lev Jul 17 >> I don't see any reason to use bash if we use POSIX and do not use any >> feature of bash. >> Quite common, there is no reason to use bash unless there is actual need. > Alon, that's true , but as I see that, all scripts currently use bash , so > the way to change that is > 1) commit this patch with bash > 2) do a separate patch that will change all scripts from bash to sh Or: 3) gradually convert scripts to use POSIX shell.... -- To view, visit http://gerrit.ovirt.org/6255 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If06ea52efb4da7c51dad8fc2b32043082ce13263 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Moran Goldboim <mgold...@redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschr...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
