Allon Mureinik has posted comments on this change. Change subject: core: Remove BusinessEntityGuidComparator class ......................................................................
Patch Set 2: Code-Review-1 (2 comments) http://gerrit.ovirt.org/#/c/32134/2/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/DiskImageDynamic.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/DiskImageDynamic.java: Line 118: } Line 119: Line 120: @Override Line 121: public int compareTo(DiskImageDynamic o) { Line 122: return BusinessEntityComparator.newGuidInstance().compare(this, o); The newGuidInstance() method is redundant - you could just use: BusinessEntityComparator.<DiskImageDynamic, Guid>newInstance().compare(this, o); Line 123: } http://gerrit.ovirt.org/#/c/32134/2/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/comparators/BusinessEntityComparator.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/comparators/BusinessEntityComparator.java: Line 19: public static <T extends BusinessEntity<ID>, ID extends Serializable & Comparable<? super ID>> BusinessEntityComparator<T, ID> newInstance() { Line 20: return new BusinessEntityComparator<T, ID>(); Line 21: } Line 22: Line 23: public static <T extends BusinessEntity<Guid>> BusinessEntityComparator<T, Guid> newGuidInstance() { This is redundant - see explanation in DiskImageDynamic. Line 24: return new BusinessEntityComparator<T, Guid>(); Line 25: } -- To view, visit http://gerrit.ovirt.org/32134 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I733bfbfdee01aa4c0bef344319e1dd471a3f2d79 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Betak <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Martin Betak <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
