Martin Betak has posted comments on this change. Change subject: core: Remove BusinessEntityGuidComparator class ......................................................................
Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/32134/2/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/DiskImageDynamic.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/DiskImageDynamic.java: Line 118: } Line 119: Line 120: @Override Line 121: public int compareTo(DiskImageDynamic o) { Line 122: return BusinessEntityComparator.newGuidInstance().compare(this, o); > The newGuidInstance() method is redundant - you could just use: Yes, I assume the whole existence of BusinessEntityGuidComparator was reduntant, only to serve as convenience to not have to specify the generic parameters (since those cannot be inferred in this case). If we don't want to have this shortcut for "Guid" Business entities I have no problem with removing this method. Line 123: } -- To view, visit http://gerrit.ovirt.org/32134 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I733bfbfdee01aa4c0bef344319e1dd471a3f2d79 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Betak <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Martin Betak <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
