Allon Mureinik has posted comments on this change. Change subject: core: Consoldated common test of add/update storage connection ......................................................................
Patch Set 2: (4 comments) http://gerrit.ovirt.org/#/c/32371/2//COMMIT_MSG Commit Message: Line 3: AuthorDate: 2014-09-03 15:07:55 +0300 Line 4: Commit: Tal Nisan <[email protected]> Line 5: CommitDate: 2014-09-03 15:07:55 +0300 Line 6: Line 7: core: Consoldated common test of add/update storage connection s/Consoldated/Consolidated/ Line 8: Line 9: AddStorageServerConnection & UpdateStorageServerConnection command tests Line 10: contained simiar tests, those common tests were extracted to a parent test Line 11: class for better readability and easier maintenance Line 5: CommitDate: 2014-09-03 15:07:55 +0300 Line 6: Line 7: core: Consoldated common test of add/update storage connection Line 8: Line 9: AddStorageServerConnection & UpdateStorageServerConnection command tests s/&/and/ Line 10: contained simiar tests, those common tests were extracted to a parent test Line 11: class for better readability and easier maintenance Line 12: Line 13: Change-Id: Iad571ca0c5788c375200847e8872706a8dfd7f3e http://gerrit.ovirt.org/#/c/32371/2/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/AddStorageServerConnectionCommandTest.java File backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/AddStorageServerConnectionCommandTest.java: Line 51: doReturn(storageDomainDao).when(command).getStorageDomainDao(); Line 52: } Line 53: Line 54: @Test Line 55: public void addPosixNonEmptyVFSType() { updatePosixEmptyVFSType() was removed - shouldn't this one be removed too? Line 56: StorageServerConnections newPosixConnection = Line 57: createPosixConnection("multipass.my.domain.tlv.company.com:/export/allstorage/data1", Line 58: StorageType.POSIXFS, Line 59: "nfs", http://gerrit.ovirt.org/#/c/32371/2/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/StorageServerConnectionTestCommon.java File backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/StorageServerConnectionTestCommon.java: Line 64: connectionDetails.setuser_name(user); Line 65: connectionDetails.setpassword(password); Line 66: return connectionDetails; Line 67: } Line 68: The tests should not be called addXYZ (since you aren't necessarily adding anymore), but testXYZ. Line 69: @Test Line 70: public void addISCSIEmptyIqn() { Line 71: StorageServerConnections newISCSIConnection = Line 72: createISCSIConnection("10.35.16.25", StorageType.ISCSI, "", "3650", "user1", "mypassword123"); -- To view, visit http://gerrit.ovirt.org/32371 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iad571ca0c5788c375200847e8872706a8dfd7f3e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
