Tal Nisan has posted comments on this change. Change subject: core: Consoldated common test of add/update storage connection ......................................................................
Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/32371/2/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/AddStorageServerConnectionCommandTest.java File backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/AddStorageServerConnectionCommandTest.java: Line 51: doReturn(storageDomainDao).when(command).getStorageDomainDao(); Line 52: } Line 53: Line 54: @Test Line 55: public void addPosixNonEmptyVFSType() { > updatePosixEmptyVFSType() was removed - shouldn't this one be removed too? This validation is for non empty which should succeed Line 56: StorageServerConnections newPosixConnection = Line 57: createPosixConnection("multipass.my.domain.tlv.company.com:/export/allstorage/data1", Line 58: StorageType.POSIXFS, Line 59: "nfs", -- To view, visit http://gerrit.ovirt.org/32371 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iad571ca0c5788c375200847e8872706a8dfd7f3e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
