Moti Asayag has posted comments on this change. Change subject: engine: Re-assign display/migration roles to mgmt network ......................................................................
Patch Set 1: Code-Review-1 (3 comments) 1. I think you should add the same behavior to DetachNetworksFromClusterCommand 2. The scope of the transaction in DetachNetworkToVdsGroupCommand should be include both network cluster removal and setting the new management network (for the sake of atomicity) http://gerrit.ovirt.org/#/c/32253/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/cluster/DetachNetworkToVdsGroupCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/cluster/DetachNetworkToVdsGroupCommand.java: Line 43: getNetworkClusterDAO().remove(getParameters().getVdsGroupId(), networkCluster.getNetworkId()); Line 44: Line 45: if (networkCluster.isDisplay()) { Line 46: getManagementNetworkCluster().setDisplay(true); Line 47: } please add a space line after a closing curly bracket (sorry...the dark force is too strong) Line 48: if (networkCluster.isMigration()) { Line 49: getManagementNetworkCluster().setMigration(true); Line 50: } Line 51: if (managementNetworkCluster != null) { Line 46: getManagementNetworkCluster().setDisplay(true); Line 47: } Line 48: if (networkCluster.isMigration()) { Line 49: getManagementNetworkCluster().setMigration(true); Line 50: } same Line 51: if (managementNetworkCluster != null) { Line 52: getNetworkClusterDAO().update(managementNetworkCluster); Line 53: } Line 54: Line 112: if (managementNetworkCluster == null) { Line 113: Guid clusterId = getParameters().getVdsGroupId(); Line 114: Network mgmt = getNetworkDAO().getByNameAndCluster(NetworkUtils.getEngineNetwork(), clusterId); Line 115: managementNetworkCluster = getNetworkClusterDAO().get(new NetworkClusterId(clusterId, mgmt.getId())); Line 116: } same Line 117: return managementNetworkCluster; Line 118: } Line 119: Line 120: private void removeNetworkFromHosts() { -- To view, visit http://gerrit.ovirt.org/32253 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1fe94bdfda672ddf51b075415a02a80ff634a90a Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <[email protected]> Gerrit-Reviewer: Lior Vernia <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
