Piotr Kliczewski has posted comments on this change. Change subject: core: cleanup - order ctr and important public methods first ......................................................................
Patch Set 7: (2 comments) http://gerrit.ovirt.org/#/c/27917/7/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java: Line 158: public void refresh() { Line 159: try { Line 160: refreshVdsRunTimeInfo(); Line 161: } finally { Line 162: try { What happens here when we fail resfresh due to networking issues? Line 163: if (_firstStatus != _vds.getStatus() && _vds.getStatus() == VDSStatus.Up) { Line 164: // use this lock in order to allow only one host updating DB and Line 165: // calling UpEvent in a time Line 166: VdsManager.cancelRecoveryJob(_vds.getId()); Line 221: if (_vds.getStatus() != VDSStatus.PreparingForMaintenance && _vds.getStatus() != VDSStatus.Maintenance) { Line 222: ResourceManager.getInstance().runVdsCommand(VDSCommandType.SetVdsStatus, Line 223: new SetVdsStatusVDSCommandParameters(_vds.getId(), VDSStatus.Error)); Line 224: } Line 225: } catch (Throwable t) { Why we are catching throwable here? Are there any specific exceptions that we expect? Line 226: log.error("Failure to refresh Vds runtime info", t); Line 227: throw t; Line 228: } Line 229: moveVDSToMaintenanceIfNeeded(); -- To view, visit http://gerrit.ovirt.org/27917 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie2fd6ef474f1e5fe6734d65f5de5c8d3592c0d12 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <[email protected]> Gerrit-Reviewer: Liran Zelkha <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
