Roy Golan has posted comments on this change. Change subject: core: cleanup - order ctr and important public methods first ......................................................................
Patch Set 7: (1 comment) http://gerrit.ovirt.org/#/c/27917/7/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java: Line 158: public void refresh() { Line 159: try { Line 160: refreshVdsRunTimeInfo(); Line 161: } finally { Line 162: try { > What happens here when we fail resfresh due to networking issues? please see refreshVdsRunTimeInfo(). it catches it and fires vdsManager.handleNetworkException(Exception, VDS) then rethrow it for logging. in general could be simplified and cleaned Line 163: if (_firstStatus != _vds.getStatus() && _vds.getStatus() == VDSStatus.Up) { Line 164: // use this lock in order to allow only one host updating DB and Line 165: // calling UpEvent in a time Line 166: VdsManager.cancelRecoveryJob(_vds.getId()); -- To view, visit http://gerrit.ovirt.org/27917 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie2fd6ef474f1e5fe6734d65f5de5c8d3592c0d12 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <[email protected]> Gerrit-Reviewer: Liran Zelkha <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
