Alon Bar-Lev has posted comments on this change. Change subject: packaging: fail the build if osinfo-defaults.properties fails to parse ......................................................................
Patch Set 1: (4 comments) http://gerrit.ovirt.org/#/c/33323/1//COMMIT_MSG Commit Message: Line 11: Line 12: this test is hooked into the packaging process and must fail it. Line 13: Line 14: MISSING - make should invoke this test. didn't decide yet how to invoke Line 15: it from Makefile at Makefile: validations: generated-files <snip> if [ "$(BUILD_VALIDATION)" != 0 ]; then \ build/shell-check.sh && \ build/python-check.sh && \ build/dbscripts-duplicate_upgrade_scripts.sh && \ ( cd build/xxx && $(MVN) -Dosinfo.properties=../../packaging/.../osinfo.properties clean test ) ; \ fi Line 16: Line 17: Change-Id: I9aead46c067134dbc59b83ad70d1715ec004587c Line 18: Bug-Url: https://bugzilla.redhat.com/1056965 http://gerrit.ovirt.org/#/c/33323/1/packaging/pom.xml File packaging/pom.xml: please move this out of packaging per our past discussion, packaging is directory to out of maven reach. put it under build/something Line 1: <project> Line 2: <modelVersion>4.0.0</modelVersion> Line 3: <parent> Line 4: <groupId>org.ovirt.engine</groupId> http://gerrit.ovirt.org/#/c/33323/1/packaging/src/test/java/OsinfoTests.java File packaging/src/test/java/OsinfoTests.java: from experience packageless classes cause issues, can you please add at least one level package name? Line 1: import org.junit.Test; Line 2: import org.ovirt.engine.core.utils.osinfo.OsinfoPropertiesParser; Line 3: Line 4: public class OsinfoTests { Line 2: import org.ovirt.engine.core.utils.osinfo.OsinfoPropertiesParser; Line 3: Line 4: public class OsinfoTests { Line 5: Line 6: public static final String OSINFO_DEFAULTS_PROPERTIES = "osinfo-defaults.properties"; it should be provided by system property. Line 7: Line 8: @Test Line 9: public void parse() { Line 10: -- To view, visit http://gerrit.ovirt.org/33323 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9aead46c067134dbc59b83ad70d1715ec004587c Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
