Alon Bar-Lev has posted comments on this change. Change subject: packaging: fail the build if osinfo-defaults.properties fails to parse ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/33323/1//COMMIT_MSG Commit Message: Line 11: Line 12: this test is hooked into the packaging process and must fail it. Line 13: Line 14: MISSING - make should invoke this test. didn't decide yet how to invoke Line 15: it from Makefile > at Makefile: ok, this is impossible as you want to run this after java build. so: all: \ generated-files \ validations \ $(BUILD_FILE) \ post-build-validations \ $(NULL) post-build-validations: if [ "$(BUILD_VALIDATION)" != 0 ]; then \ ( cd build/xxx && $(MVN) -Dosinfo.properties=../../packaging/.../osinfo.properties clean test ); \ fi Line 16: Line 17: Change-Id: I9aead46c067134dbc59b83ad70d1715ec004587c Line 18: Bug-Url: https://bugzilla.redhat.com/1056965 -- To view, visit http://gerrit.ovirt.org/33323 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9aead46c067134dbc59b83ad70d1715ec004587c Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
