Allon Mureinik has posted comments on this change. Change subject: core: create default disk profile for attached SD ......................................................................
Patch Set 1: Code-Review-1 (1 comment) http://gerrit.ovirt.org/#/c/33428/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AttachStorageDomainToPoolCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AttachStorageDomainToPoolCommand.java: Line 156: && getDbFacade().getDiskProfileDao() Line 157: .getAllForStorageDomain(getStorageDomain().getId()) Line 158: .isEmpty()) { Line 159: getDiskProfileDao().save(DiskProfileHelper.createDiskProfile(getStorageDomain().getId(), Line 160: getStorageDomainName())); AFAIK, this should be compensated if the attach fails. Line 161: } Line 162: } Line 163: Line 164: runVdsCommand(VDSCommandType.AttachStorageDomain, -- To view, visit http://gerrit.ovirt.org/33428 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic59d6f38096fb5e20fee5b9b4705b4603fdf0d4f Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Arik Hadas <[email protected]> Gerrit-Reviewer: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Liron Aravot <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
