Maor Lipchuk has posted comments on this change. Change subject: core: create default disk profile for attached SD ......................................................................
Patch Set 2: (2 comments) http://gerrit.ovirt.org/#/c/33428/2/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AttachStorageDomainToPoolCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AttachStorageDomainToPoolCommand.java: Line 153: } Line 154: } Line 155: // Creating default disk profile for existing storage domain. Line 156: if (FeatureSupported.storageQoS(getStoragePool().getcompatibility_version()) Line 157: && getDbFacade().getDiskProfileDao() /s/getDbFacade().getDiskProfileDao()/getDiskProfileDao() Line 158: .getAllForStorageDomain(getStorageDomain().getId()) Line 159: .isEmpty()) { Line 160: final DiskProfile diskProfile = Line 161: DiskProfileHelper.createDiskProfile(getStorageDomain().getId(), Line 168: getCompensationContext().stateChanged(); Line 169: return null; Line 170: } Line 171: }); Line 172: } Consider to extract this to a seperate method Line 173: } Line 174: Line 175: runVdsCommand(VDSCommandType.AttachStorageDomain, Line 176: new AttachStorageDomainVDSCommandParameters(getParameters().getStoragePoolId(), -- To view, visit http://gerrit.ovirt.org/33428 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic59d6f38096fb5e20fee5b9b4705b4603fdf0d4f Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Arik Hadas <[email protected]> Gerrit-Reviewer: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Liron Aravot <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
