Tim Speetjens has uploaded a new change for review. Change subject: utils: Suppress warnings for deprecation and add appropriate TODO message ......................................................................
utils: Suppress warnings for deprecation and add appropriate TODO message Change-Id: I5f5fe8816e006276fce3300ece657be8de21823f Signed-off-by: Tim Speetjens <[email protected]> --- M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfReader.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfVmWriter.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/pm/VdsFenceOptions.java M backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/ovf/OvfManagerTest.java 4 files changed, 8 insertions(+), 0 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/85/33685/1 diff --git a/backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfReader.java b/backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfReader.java index 16c1b12..4590d5f 100644 --- a/backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfReader.java +++ b/backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfReader.java @@ -46,6 +46,8 @@ import org.w3c.dom.Node; import org.w3c.dom.NodeList; +// TODO refactor to avoid use of deprecated method VmNetworkInterface.setNetworkName +@SuppressWarnings("deprecation") public abstract class OvfReader implements IOvfBuilder { protected OsRepository osRepository = SimpleDependecyInjector.getInstance().get(OsRepository.class); protected ArrayList<DiskImage> _images; diff --git a/backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfVmWriter.java b/backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfVmWriter.java index 97bd737..ca33e4a 100644 --- a/backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfVmWriter.java +++ b/backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfVmWriter.java @@ -20,6 +20,8 @@ import org.ovirt.engine.core.compat.RegexOptions; import org.ovirt.engine.core.compat.Version; +// TODO refactor to avoid use of deprecated classes in compat module +@SuppressWarnings("deprecation") public class OvfVmWriter extends OvfWriter { private static final String EXPORT_ONLY_PREFIX = "exportonly_"; private OsRepository osRepository = SimpleDependecyInjector.getInstance().get(OsRepository.class); diff --git a/backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/pm/VdsFenceOptions.java b/backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/pm/VdsFenceOptions.java index 7975b79..f88b547 100644 --- a/backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/pm/VdsFenceOptions.java +++ b/backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/pm/VdsFenceOptions.java @@ -15,6 +15,8 @@ import org.ovirt.engine.core.utils.log.Log; import org.ovirt.engine.core.utils.log.LogFactory; +// TODO refactor to avoid use of deprecated classes in compat module +@SuppressWarnings("deprecation") public class VdsFenceOptions implements Serializable { private static final long serialVersionUID = -8832636627473217232L; diff --git a/backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/ovf/OvfManagerTest.java b/backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/ovf/OvfManagerTest.java index 5429eaf..076546e 100644 --- a/backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/ovf/OvfManagerTest.java +++ b/backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/ovf/OvfManagerTest.java @@ -30,6 +30,8 @@ import org.ovirt.engine.core.compat.Version; import org.ovirt.engine.core.utils.MockConfigRule; +// TODO refactor to avoid use of deprecated method VmNetworkInterface.setNetworkName +@SuppressWarnings("deprecation") @RunWith(MockitoJUnitRunner.class) public class OvfManagerTest { -- To view, visit http://gerrit.ovirt.org/33685 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I5f5fe8816e006276fce3300ece657be8de21823f Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tim Speetjens <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
